Skip to content

Add shortname option for kms-key-name to firestore:databases:create #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add shortname option for kms-key-name to firestore:databases:create #7510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48603a9
Add shortname option for kms-key-name to firestore:databases:create
TomasMorton Jul 30, 2024
2d76d2d
Merge branch 'master' into tm-firestore-create-db-kms-key-name-short
joehan Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/commands/firestore-databases-create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ export const command = new Command("firestore:databases:create <database>")
)
// TODO(b/356137854): Remove allowlist only message once feature is public GA.
.option(
"--kms-key-name <kmsKeyName>",
"The resource ID of a Cloud KMS key. If set, the database created will be a Customer-managed Encryption Key (CMEK) database encrypted with this key. This feature is allowlist only in initial launch.",
"-k, --kms-key-name <kmsKeyName>",
"The resource ID of a Cloud KMS key. If set, the database created will be a " +
"Customer-managed Encryption Key (CMEK) database encrypted with this key. " +
"This feature is allowlist only in initial launch.",
)
.before(requirePermissions, ["datastore.databases.create"])
.before(warnEmulatorNotSupported, Emulators.FIRESTORE)
Expand Down