Skip to content

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Aug 6, 2024

Description

Preemptively merged #7522 and missed some relevant comments.

@joehan joehan requested a review from dconeybe August 6, 2024 18:49
@joehan joehan enabled auto-merge (squash) August 6, 2024 22:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.06%. Comparing base (d646372) to head (43c6b7e).
Report is 10 commits behind head on master.

Files Patch % Lines
src/init/features/dataconnect/sdk.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7531      +/-   ##
==========================================
- Coverage   53.39%   53.06%   -0.33%     
==========================================
  Files         390      391       +1     
  Lines       26733    26987     +254     
  Branches     5505     5567      +62     
==========================================
+ Hits        14273    14320      +47     
- Misses      11187    11388     +201     
- Partials     1273     1279       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan merged commit f213388 into master Aug 6, 2024
@joehan joehan deleted the jh-android-fixes branch August 6, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants