Fix wrong project issue #7752
Merged
Fix wrong project issue #7752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
reviewed
Sep 26, 2024
firebase-vscode/src/core/index.ts
Outdated
| "firebase init dataconnect", // how you name the task | ||
| "firebase init dataconnect", // Shows up as MyTask: name | ||
| new vscode.ShellExecution(`${settings.firebasePath} init dataconnect`), | ||
| new vscode.ShellExecution(`${settings.firebasePath} init dataconnect ${currentProjectId.value}`), |
Contributor
There was a problem hiding this comment.
-P ${currentProjectId.value}?
Contributor
There was a problem hiding this comment.
nit: Is --project more clear?
fredzqm
approved these changes
Sep 26, 2024
yuchenshi
reviewed
Sep 27, 2024
| "firebase init dataconnect", // how you name the task | ||
| "firebase init dataconnect", // Shows up as MyTask: name | ||
| new vscode.ShellExecution(`${settings.firebasePath} init dataconnect`), | ||
| new vscode.ShellExecution(`${settings.firebasePath} init dataconnect --project ${currentProjectId.value}`), |
Member
There was a problem hiding this comment.
Is this guaranteed to be non-empty when the init button is shown? I thought there's a project selection prompt in the CLI or something
| // as when oh-my-zsh asking for (Y/n) to updates during startup. | ||
| // Consider using an non-interactive shell. | ||
| terminal.sendText(command); | ||
| terminal.sendText(`${command} -P ${currentProjectId.value}`); |
Member
There was a problem hiding this comment.
Shall we use the long form --project for consistency and readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the VSCE would execute commands in the directory default project instead of in the selected project.