Skip to content

Conversation

@ninachaubal
Copy link

Superstatic already supports live reload, which is awesome for development. This adds it as an option for firebase serve.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ninachaubal
Copy link
Author

@googlebot I signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@mbleigh
Copy link
Contributor

mbleigh commented Oct 27, 2015

@ninachaubal thanks for the PR! We're currently evaluating some of the internals of Superstatic and what we can do to make sure it's a lean, purpose-built library. It's possible (not decided yet) that livereload will be pulled back out with the understanding that it'll be easy to add back in via middleware.

As such, I'm going to close this PR, but it is very much appreciated and I'll count this as a vote for figuring out a smooth livereload process for the Firebase CLI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants