Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Add initial delay when loading python functions (#8239)
- Enforce webframeworks enablement only on webframeworks sites (#8168)
- Fix issue where `apps:init` throws an error upon app creation
2 changes: 1 addition & 1 deletion src/commands/apps-init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
out?: string | boolean;
}

function logUse(platform: AppPlatform, filePath: string) {

Check warning on line 27 in src/commands/apps-init.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing return type on function
switch (platform) {
case AppPlatform.WEB:
logger.info(`
Expand Down Expand Up @@ -59,7 +59,7 @@
}
}

function toAppPlatform(str: string) {

Check warning on line 62 in src/commands/apps-init.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing return type on function
switch (str.toUpperCase()) {
case Platform.ANDROID:
return Platform.ANDROID as unknown as AppPlatform.ANDROID;
Expand All @@ -83,16 +83,16 @@
const config = options.config;
const appDir = process.cwd();
// auto-detect the platform
const detectedPlatform = platform ? toAppPlatform(platform) : await getPlatform(appDir, config);

Check warning on line 86 in src/commands/apps-init.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string`

let sdkConfig: AppConfig | undefined;
while (sdkConfig === undefined) {
try {
sdkConfig = await getSdkConfig(options, getAppPlatform(detectedPlatform), appId);

Check warning on line 91 in src/commands/apps-init.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string | undefined`
} catch (e) {
if ((e as Error).message.includes("associated with this Firebase project")) {
const projectId = needProjectId(options);
await sdkInit(platform, { ...options, project: projectId });
await sdkInit(detectedPlatform, { ...options, project: projectId });
} else {
throw e;
}
Expand Down
Loading