Remove protocol from DATA_CONNECT_EMULATOR_HOST. #8396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol should never be set according to go/emulator-suite-admin-sdk and setting it breaks the Node.js Admin SDK. Symptoms include error messages like `getaddrinfo ENOTFOUND http` because it's trying to resolve the word `http` via DNS. I have not tested whether the client SDKs tolerates it but let's just settle on the correct behavior.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8396 +/- ##
==========================================
+ Coverage 51.08% 51.20% +0.12%
==========================================
Files 425 425
Lines 30374 30390 +16
Branches 6223 6227 +4
==========================================
+ Hits 15516 15562 +46
+ Misses 13471 13439 -32
- Partials 1387 1389 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joehan
reviewed
Apr 2, 2025
yuchenshi
changed the title
maneesht
approved these changes
Apr 2, 2025
joehan
approved these changes
Apr 2, 2025
Member
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Thank you for adding the detailed comments too!
blidd-google
pushed a commit
that referenced
this pull request
May 12, 2025
This unbreaks the Node.js Admin SDK who doesn't expect a protocol. The other env vars are unchanged for now but comments were added to clarify their use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The protocol should never be set according to go/emulator-suite-admin-sdk and setting it breaks the Node.js Admin SDK.
Symptoms include error messages like
getaddrinfo ENOTFOUND httpbecause it's trying to resolve the wordhttpvia DNS.The other environment variable
FIREBASE_DATA_CONNECT_EMULATOR_HOSTis consumed by the JS SDK, which requires a protocol right now. We've decided not to remove the protocol for now to avoid breaking the JS SDK (e.g. when used within the Functions emulator where this env var is automatically set).Scenarios Tested
Not tested
Sample Commands
N/A