fix: fix GA4 under-reporting of Functions runtime config usage by restoring has_runtime_config tracking during deploy.

[taeold]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the tracking of runtime configuration usage. The change ensures that a specific analytics metric accurately captures whether non-default runtime configurations are present, improving data integrity for reporting purposes.

Highlights

• Bug Fix: Corrected an issue where the usage of runtime configuration was not being accurately tracked, specifically for the has_runtime_config GA4 metric.
• Metric Accuracy: Implemented logic to ensure the has_runtime_config metric correctly reflects the presence of legacy runtime configuration keys (any keys other than the default 'firebase').

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces tracking for the use of legacy runtime configurations. A new property, hasRuntimeConfig, is added to the deployment context. This property is set to true if any runtime configuration keys other than the default 'firebase' key are present. This is then used for GA4 analytics to monitor the usage of this legacy feature. The implementation is clear, correct, and consistent with similar checks elsewhere in the codebase. The change is well-contained and looks good.