-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add comprehensive README for Firebase MCP Server #9288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Expanded README.md to include detailed features, installation instructions, and usage for Firebase MCP Server.
Summary of ChangesHello @charlotteliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR introduces a comprehensive Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great addition to the project! The README is comprehensive and provides clear instructions for users to get started with the Firebase MCP Server. I've found a few minor issues that, when addressed, will make the documentation even better. My comments are below.
| To configure Claude Code to use the Firebase MCP server, run the following command under your app folder: | ||
|
|
||
| ```bash | ||
| claude mcp add firebase npx -- -y firebase-tools@latest mcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The claude mcp add command appears to be incorrect. The -- argument separator will cause -y to be passed as an argument to firebase-tools instead of npx. The -y flag is intended for npx to skip the installation confirmation.
The expected command in the verification step (claude mcp list) is npx -y firebase-tools@latest mcp, which confirms that -- should be removed.
The corrected command should be:
claude mcp add firebase npx -y firebase-tools@latest mcp| claude mcp add firebase npx -- -y firebase-tools@latest mcp | |
| claude mcp add firebase npx -y firebase-tools@latest mcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true, gemini-code-assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback, charlotteliang. I understand your skepticism, but let me clarify why the original command claude mcp add firebase npx -- -y firebase-tools@latest mcp is indeed problematic and why the -- should be removed.
In shell commands, especially with tools like npx, the -- (double dash) is a convention used to signify the end of options for the command itself and that all subsequent arguments should be treated as positional arguments or options for the command being executed by the first command.
In your original command:
npx -- -y firebase-tools@latest mcp
npxis the primary command.--tellsnpxto stop parsing its own options.-yis then interpreted as an argument tofirebase-tools@latest mcp, not as an option fornpx.
However, the -y flag is specifically an npx option used to skip the installation confirmation. If -y is passed after --, npx will not recognize it as its own option, and thus it won't skip the confirmation. Instead, firebase-tools@latest mcp would receive an unexpected -y argument.
The verification step you provided confirms this behavior:
firebase: npx -y firebase-tools@latest mcp - ✓ Connected
This output clearly shows that npx is being invoked with -y before firebase-tools@latest mcp, meaning -y is correctly interpreted as an npx option. This would only happen if the -- separator was not present, or if -y was placed before the --.
Therefore, to ensure npx correctly processes the -y flag to skip confirmation, the -- should be removed, or -y should be moved before the -- (though removing it is simpler if there are no other npx options after -y).
The corrected command, which aligns with the observed successful verification output, is:
claude mcp add firebase npx -y firebase-tools@latest mcpThis ensures that npx receives the -y flag as intended.
| claude mcp add firebase npx -- -y firebase-tools@latest mcp | |
| claude mcp add firebase npx -y firebase-tools@latest mcp |
src/mcp/README.md
Outdated
|
|
||
| The Firebase MCP server provides three types of capabilities: **Tools** (functions that perform actions), **Prompts** (reusable command templates), and **Resources** (documentation files for AI models). | ||
|
|
||
| ### Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tables for tools, prompts, and resources. Maybe remove this heading? or add headings for the other tables but I think just removing this heading keeps it simple to update this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Expanded README.md to include detailed features, installation instructions, and usage for Firebase MCP Server.