-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add comprehensive README for Firebase MCP Server #9288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
claude mcp addcommand appears to be incorrect. The--argument separator will cause-yto be passed as an argument tofirebase-toolsinstead ofnpx. The-yflag is intended fornpxto skip the installation confirmation.The expected command in the verification step (
claude mcp list) isnpx -y firebase-tools@latest mcp, which confirms that--should be removed.The corrected command should be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true, gemini-code-assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback, charlotteliang. I understand your skepticism, but let me clarify why the original command
claude mcp add firebase npx -- -y firebase-tools@latest mcpis indeed problematic and why the--should be removed.In shell commands, especially with tools like
npx, the--(double dash) is a convention used to signify the end of options for the command itself and that all subsequent arguments should be treated as positional arguments or options for the command being executed by the first command.In your original command:
npx -- -y firebase-tools@latest mcpnpxis the primary command.--tellsnpxto stop parsing its own options.-yis then interpreted as an argument tofirebase-tools@latest mcp, not as an option fornpx.However, the
-yflag is specifically annpxoption used to skip the installation confirmation. If-yis passed after--,npxwill not recognize it as its own option, and thus it won't skip the confirmation. Instead,firebase-tools@latest mcpwould receive an unexpected-yargument.The verification step you provided confirms this behavior:
This output clearly shows that
npxis being invoked with-ybeforefirebase-tools@latest mcp, meaning-yis correctly interpreted as annpxoption. This would only happen if the--separator was not present, or if-ywas placed before the--.Therefore, to ensure
npxcorrectly processes the-yflag to skip confirmation, the--should be removed, or-yshould be moved before the--(though removing it is simpler if there are no othernpxoptions after-y).The corrected command, which aligns with the observed successful verification output, is:
This ensures that
npxreceives the-yflag as intended.