Skip to content

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Oct 8, 2025

Description

These placeholder guides slipped in from an initial draft and shouldn't be available yet.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR removes placeholder product guides (init_data_connect and init_rtdb) from src/mcp/resources/index.ts to prevent their premature exposure, as they were included from an initial draft and are not yet ready.

Highlights

  • Intent: This pull request aims to prevent the exposure of placeholder product guides that were inadvertently included in an initial draft. The guides for 'data_connect' and 'rtdb' are being removed from the list of available resources.
  • Changes: The primary change involves modifying src/mcp/resources/index.ts. Specifically, the imports for init_data_connect and init_rtdb are removed, and these two resources are also removed from the resources array export. This effectively stops these placeholder guides from being exposed.
  • Reviewer Activity: No specific reviewer activity has been noted in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the placeholder product guides from the active resources. However, it leaves behind unreferenced files, which should be cleaned up. See my comment for details.

Comment on lines 7 to -11
import { init_firestore } from "./guides/init_firestore";
import { init_firestore_rules } from "./guides/init_firestore_rules";
import { init_hosting } from "./guides/init_hosting";
import { init_rtdb } from "./guides/init_rtdb";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

With the removal of the imports for init_data_connect and init_rtdb, their corresponding files are now unreferenced and have become dead code. To maintain a clean codebase, these files should be deleted as part of this pull request.

The files to be deleted are:

  • src/mcp/resources/guides/init_data_connect.ts
  • src/mcp/resources/guides/init_rtdb.ts

Leaving dead code in the repository can lead to confusion for future developers and increases maintenance overhead.

@joehan joehan merged commit 1a5e085 into master Oct 9, 2025
48 checks passed
@joehan joehan deleted the jh-cleanup branch October 9, 2025 16:01
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants