-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Stop exposing placeholder product guides #9290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR removes placeholder product guides ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the placeholder product guides from the active resources. However, it leaves behind unreferenced files, which should be cleaned up. See my comment for details.
| import { init_firestore } from "./guides/init_firestore"; | ||
| import { init_firestore_rules } from "./guides/init_firestore_rules"; | ||
| import { init_hosting } from "./guides/init_hosting"; | ||
| import { init_rtdb } from "./guides/init_rtdb"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the removal of the imports for init_data_connect and init_rtdb, their corresponding files are now unreferenced and have become dead code. To maintain a clean codebase, these files should be deleted as part of this pull request.
The files to be deleted are:
src/mcp/resources/guides/init_data_connect.tssrc/mcp/resources/guides/init_rtdb.ts
Leaving dead code in the repository can lead to confusion for future developers and increases maintenance overhead.
Description
These placeholder guides slipped in from an initial draft and shouldn't be available yet.