Skip to content

Stop exposing placeholder product guides #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

Stop exposing placeholder product guides #9290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/mcp/resources/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,27 @@
import { init_ai } from "./guides/init_ai";
import { init_auth } from "./guides/init_auth";
import { init_backend } from "./guides/init_backend";
import { init_data_connect } from "./guides/init_data_connect";
import { init_firestore } from "./guides/init_firestore";
import { init_firestore_rules } from "./guides/init_firestore_rules";
import { init_hosting } from "./guides/init_hosting";
import { init_rtdb } from "./guides/init_rtdb";
Comment on lines 7 to -11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

With the removal of the imports for init_data_connect and init_rtdb, their corresponding files are now unreferenced and have become dead code. To maintain a clean codebase, these files should be deleted as part of this pull request.

The files to be deleted are:

  • src/mcp/resources/guides/init_data_connect.ts
  • src/mcp/resources/guides/init_rtdb.ts

Leaving dead code in the repository can lead to confusion for future developers and increases maintenance overhead.

import { ServerResource, ServerResourceTemplate } from "../resource";
import { trackGA4 } from "../../track";

export const resources = [
init_backend,
init_ai,
init_data_connect,
init_firestore,
init_firestore_rules,
init_rtdb,
init_auth,
init_hosting,
];

export const resourceTemplates = [docs];

export async function resolveResource(

Check warning on line 24 in src/mcp/resources/index.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Missing JSDoc comment
uri: string,
ctx: McpContext,
track: boolean = true,

Check warning on line 27 in src/mcp/resources/index.ts

View workflow job for this annotation

GitHub Actions / lint (20) 

Type boolean trivially inferred from a boolean literal, remove type annotation
): Promise<
| ({
result: ReadResourceResult;
Expand Down
Loading