-
Notifications
You must be signed in to change notification settings - Fork 51
[Firebase AI] Add Live API transcripts #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for audio transcription within the Firebase AI Live API. It enables the system to capture and provide both input and output speech transcripts during live sessions, enhancing the interactive AI experience by making the spoken content directly accessible. This is achieved through new configuration options and updates to the API's response structures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for receiving input and output transcripts from the Firebase AI Live API. The changes introduce new configuration structs (AudioTranscriptionConfig) and response types (Transcription) to handle this functionality. The implementation correctly adds the new fields to the API requests and parses them from the responses. My review focuses on improving the maintainability of how the transcription configurations are passed to the backend. The current method of adding them to one dictionary and then moving them to another is a bit complex and brittle. I've suggested a refactoring to simplify this logic, making the code cleaner and more robust. Overall, this is a great addition of a new feature.
Description
Add the ability to receive input and output transcripts from the Firebase AI Live API.
Testing
Running tests locally.
Type of Change
Place an
xthe applicable box: