Skip to content

Conversation

@a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Include subfolders when gathering the docs for Firebase AI. Exclude the Internal folder


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/19557362852


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Firebase AI reference documentation was not fully capturing all relevant C# source files. The change updates the documentation gathering logic to recursively include C# files from subdirectories, thereby ensuring that all public APIs are properly documented. Concurrently, it introduces a filter to exclude internal implementation files from the documentation, maintaining a clear separation between public and private interfaces.

Highlights

  • Documentation Gathering Fix: The pull request addresses a bug in how reference documentation is gathered for Firebase AI, specifically for C# files.
  • Recursive File Inclusion: The documentation generation process now recursively includes C# source files from all subfolders within the src/ directory, ensuring comprehensive coverage.
  • Exclusion of Internal Files: Files located in the src/Internal directory are now explicitly excluded from the documentation sources, preventing internal implementation details from being exposed in the public API documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CMake configuration to recursively gather C# source files for documentation, while correctly excluding files from the Internal directory. The approach is generally correct, but the regex used for filtering could be fragile. I've provided a suggestion to use relative paths and an anchored regex to make the filtering more robust and prevent accidental exclusion of files in edge cases.

Copy link
Contributor

@AustinBenoit AustinBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-maurice a-maurice merged commit 622331d into main Nov 26, 2025
15 checks passed
@a-maurice a-maurice deleted the am-imagen_ref_docs branch November 26, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants