Skip to content

Update the Swift Package version automatically#1428

Merged
a-maurice merged 3 commits intomainfrom
am-spm_update
Apr 15, 2026
Merged

Update the Swift Package version automatically#1428
a-maurice merged 3 commits intomainfrom
am-spm_update

Conversation

@a-maurice
Copy link
Copy Markdown
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Update the FIREBASE_SPM_VERSION number automatically. Note, this assumes the version number is the same as Cocoapods, which it has consistently been for a while, so should be a valid assumption.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from AustinBenoit April 15, 2026 20:37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the scripts/update_versions.py script to include logic for updating FIREBASE_SPM_VERSION by reusing the iOS Pod version. The review feedback identifies a potential TypeError if the version retrieval fails and suggests optimizing the script to avoid redundant function calls that perform disk I/O.

Comment thread scripts/update_versions.py Outdated
@a-maurice a-maurice enabled auto-merge (squash) April 15, 2026 20:59
@a-maurice a-maurice merged commit a11dece into main Apr 15, 2026
4 checks passed
@a-maurice a-maurice deleted the am-spm_update branch April 16, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants