build_testapps.py suppresses Dynamic Links on tvOS #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TLDR; Instead of fixing the build matrix in our workflows, which is quite rigid across all targets, this change updates the
build_testapps.pyto suppress its build of Dynamic Links even if its passed in as one the provided targets on tvOS.The
Unity SDK buildworkflow supplies theIntegration testsworkflow with the full list of SDKs to test against as part of the nightly build process. This has traditionally been fine since all our SDKs were supported by all build targets.However, tvOS doesn't support Dynamic Links. When fed the entirety of SDKs as build targets the
build_testapps.pyscript would build the testapp a tvOS Dynamic Links testapp. The resulting artfiact would be a shell of an application with the C# definitions (as they're shared across tvOS and iOS in the .dlls) but with no C++ implementation. Thetest_simulator.pyscript would then find this errant testapp and blindly attempt to run it. However, the testapp would error-out upon execution due to the lack of C++ symbols.This change suppresses the build of the Dynamic Links test app in
build_testapps.py. With no testapp built,test_simualtor.pyis ignorant of the fact that one test is missing, and runs all of the others successfully.Testing
Integration Test CI
Type of Change
Place an
xthe applicable box: