Skip to content

Uninstall platforms;android-33-ext4 when building testapps #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Uninstall platforms;android-33-ext4 when building testapps #604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0abbb
Debug the uninstallation of android 33
AlmostMatt Jan 19, 2023
a2f13dc
simplify the script a bit
AlmostMatt Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/gha/build_testapps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,17 @@ def patch_android_env(unity_version):
# If this continues to be a problem, this logic might need to be smarter, to remove all versions newer than 32,
# but currently the GitHub runners have 33 as their max.
logging.info("Uninstall Android platform android-33")
_run([sdkmanager_path, "--uninstall", "platforms;android-33"], check=False)
_run([sdkmanager_path, "--uninstall", "platforms;android-33", "platforms;android-33-ext4"], check=False)
except Exception as e:
logging.exception("Failed to uninstall Android platform android-33")


try:
# List the installed packages to make it easier to notice if any incompatible packages are present.
logging.info("Listing installed sdks")
_run([sdkmanager_path, "--list_installed"], check=False)
except Exception as e:
logging.info(str(e))

os.environ["UNITY_ANDROID_SDK"]=os.environ["ANDROID_HOME"]
os.environ["UNITY_ANDROID_NDK"]=os.environ["ANDROID_NDK_HOME"]
os.environ["UNITY_ANDROID_JDK"]=os.environ["JAVA_HOME"]
Expand Down