Migrate to Nuxt 3 #361
Merged
Migrate to Nuxt 3 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Feb 19, 2025
jamesdaniels
commented
Feb 19, 2025
jamesdaniels
commented
Feb 19, 2025
jamesdaniels
commented
Feb 19, 2025
jhuleatt
approved these changes
Feb 20, 2025
Contributor
jhuleatt
left a comment
jhuleatt
left a comment
There was a problem hiding this comment.
Thanks for trudging through this upgrade @jamesdaniels! I clicked around https://web-frameworks-e2e.web.app/ and all seems to work
Comment on lines
-57
to
-59
| export function daysAgo (date: Date) { | ||
| return formatDistanceToNow(date) + ' ago' | ||
| } |
Contributor
There was a problem hiding this comment.
is this unused now? just double checking it wasn't removed by accident
Member
Author
There was a problem hiding this comment.
yeah, i don't think it's worth having a separate util function just to add "ago", heh. If we weren't using a node module for fuzzy dates and it were anymore complex, i could see it
…oot (no common tsc version)
jhuleatt
reviewed
Feb 20, 2025
frontend/package.json
Outdated
Comment on lines
17
to
18
| "deploy": "npm run generate && npx -y firebase-tools --project=default deploy", | ||
| "deploy:hosting": "npm run generate && npx -y firebase-tools --project=default deploy --only hosting" |
Contributor
There was a problem hiding this comment.
are these redundant since the makefile does the same thing?
Member
Author
There was a problem hiding this comment.
it seems the makefile is unused in the ci/cd pipeline, i'll clean that up when i update functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not get a local environment setup, it turns out everything is very outdated. Starting the dust off effort with the frontend, will move to modernize the Cloud Functions and add an App Hosting category in follow up PRs.
dompurifyto reduce XSS vulnerability@docsearch/jsinto package.jsonfir-ossyet, staged here https://web-frameworks-e2e.web.app/fir-oss