feat(firestore): add string manipulation functions for Android and iOS - #18493
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
demolaf
left a comment
demolaf
left a comment
There was a problem hiding this comment.
LGTM, maybe we can add an e2e test for string_replace_all?
| case "string_replace_all": | ||
| { | ||
| Expression expression = parseChild(args, "expression"); | ||
| Expression find = parseChild(args, "find"); | ||
| Expression replacement = parseChild(args, "replacement"); | ||
| return expression.stringReplaceAll(find, replacement); | ||
| } |
There was a problem hiding this comment.
could we add e2e tests for this too?
There was a problem hiding this comment.
Good catch. I've added it
3 participants
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Fixes #18488
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?