feat(auth, android): Play Games provider sign-in support#12201
Merged
Conversation
Lyokone
approved these changes
Jan 29, 2024
Contributor
Lyokone
left a comment
There was a problem hiding this comment.
Looks good, I wonder if we should add a section in the docs as well?
Salakar
reviewed
Jan 29, 2024
Salakar
reviewed
Jan 29, 2024
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
exaby73
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Writing the code is easier than receiving the
serverAuthCodefor use in signing in with Play Games provider. Some changes required are already in the example app.Configuration
Requires setting up a game app on the Play console and following the two sections in the Firebase documentation here:
Do not to forget to "publish" the app on the Play console. (For Invertase devs, it is on the Play console under "Play Game App").
Play Game SDK setup
I couldn't find any Dart packages that retrieve the serverAuthCode so I setup myself using the Play Games SDK.
I would not follow the Firebase docs as it has a tiny snippet of the deprecated Play Games SDK (v1) here: https://firebase.google.com/docs/auth/android/play-games#integrate_play_games_sign-in_into_your_game
I would follow the Play Games V2 SDK documentation here: https://developers.google.com/games/services/android/signin
I actually tested directly in the FlutterFirebaseAuthPlugin. A couple of required changes are included in this PR for the auth example app, but I had to add a dependency to the firebase_auth plugin
build.gradle(not included in PR):For implementation, I had to do the following to get the
serverAuthCode:Also add in instance creation of class:
Related Issues
closes #12190
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?