-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(database, web): migrate web to js_interop to be compatible with WASM #12530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // ignore_for_file: public_member_api_docs | ||
|
|
||
| import 'dart:async'; | ||
| import 'dart:js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch
TarekkMA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
…h WASM (firebase#12530) * feat(database, web): migrate web to js_interop to be compatible with WASM * feat(performance, web): migrate web to js_interop to be compatible with WASM * more * more * more * testing * fix typing * tests * exceptions * working?? * fix * remove dart:js
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
#12466
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?