Skip to content

Conversation

@Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Mar 26, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

#12466

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review March 26, 2024 11:57
@Lyokone Lyokone changed the title feat(database, web): migrate web to js_interop to be compatible with … feat(database, web): migrate web to js_interop to be compatible with WASM Mar 26, 2024
// ignore_for_file: public_member_api_docs

import 'dart:async';
import 'dart:js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch

@Lyokone Lyokone requested a review from TarekkMA March 26, 2024 12:16
Copy link
Contributor

@TarekkMA TarekkMA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lyokone Lyokone merged commit 07b594f into master Mar 26, 2024
@Lyokone Lyokone deleted the feat/wasmdatabase branch March 26, 2024 12:43
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
guide-loclt pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…h WASM (firebase#12530)

* feat(database, web): migrate web to js_interop to be compatible with WASM

* feat(performance, web): migrate web to js_interop to be compatible with WASM

* more

* more

* more

* testing

* fix typing

* tests

* exceptions

* working??

* fix

* remove dart:js
@firebase firebase locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants