Skip to content

Conversation

@argo1
Copy link
Contributor

@argo1 argo1 commented May 15, 2025

Description

Fix firestore cleanup. Currently it's looping over dictionary keys not values.

Related Issues

Have not created an issue.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented May 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@argo1 argo1 changed the title Fix firestore cleanup to use valus not keys. Fix firestore cleanup to use values not keys. May 15, 2025
@argo1 argo1 changed the title Fix firestore cleanup to use values not keys. Fix firestore cleanup crash. By using use values not keys. May 16, 2025
@argo1 argo1 changed the title Fix firestore cleanup crash. By using use values not keys. Fix firestore cleanup crash. By using values not keys. May 16, 2025
@SelaseKay SelaseKay changed the title Fix firestore cleanup crash. By using values not keys. fix(firestore): correctly iterate over dictionary values in cleanup May 27, 2025
@SelaseKay
Copy link
Contributor

Hi @argo1, kindly sign the CLA

@SelaseKay SelaseKay merged commit c874554 into firebase:main May 29, 2025
23 of 29 checks passed
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants