Skip to content

Conversation

@Gustl22
Copy link
Contributor

@Gustl22 Gustl22 commented May 21, 2025

Description

These docs provide a way to write a notification service extension in Swift instead of Objective-C

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Gustl22
Copy link
Contributor Author

Gustl22 commented May 21, 2025

The code block format was taken from (as ref):

I don't know how this page looks rendered though.

@Gustl22
Copy link
Contributor Author

Gustl22 commented May 21, 2025

The docs for iOS also describe a similar approach. It should maybe also be rewritten to work with Swift:
https://firebase.google.com/docs/cloud-messaging/ios/send-image

These docs aren't available publicly in this organization.

@Gustl22
Copy link
Contributor Author

Gustl22 commented May 29, 2025

Just to ensure: Is there a possibility for a rendered preview before merge?

@russellwheatley
Copy link
Member

@Gustl22 - that's not available I'm afraid.

@russellwheatley russellwheatley merged commit e00fafc into firebase:main May 30, 2025
2 checks passed
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants