fix(auth,ios): fix crash that could happen when reloading currentUser informations

[Lyokone]

Description

Fix SIGSEGV crash (absoluteString > dereference garbage pointer 0xdeadbeef) on iOS caused by a race condition in async completion blocks. Five methods (reloadApp, updateEmail, updatePassword, updatePhoneNumber, updateProfile) were re-fetching auth.currentUser inside async callbacks instead of using the locally captured currentUser, leading to use-after-free when auth state changed concurrently. Also fixed PigeonParser to evaluate photoURL.absoluteString once into a local variable instead of twice in a ternary expression.

Related Issues

• Fixes [firebase_auth]: SIGSEGV absoluteString > Attempted to dereference garbage pointer at 0xdeadbeef. #17933

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (melos run analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

• Yes, this is a breaking change.
• No, this is not a breaking change.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.