Skip to content

fix(messaging,android): fix call race that could happen when using requestPermission#18256

Merged
russellwheatley merged 2 commits intomainfrom
fix/18246
May 7, 2026
Merged

fix(messaging,android): fix call race that could happen when using requestPermission#18256
russellwheatley merged 2 commits intomainfrom
fix/18246

Conversation

@Lyokone
Copy link
Copy Markdown
Contributor

@Lyokone Lyokone commented May 6, 2026

Description

Fixes an Android crash in firebase_messaging when concurrent requestPermission() calls race through the native permission manager. The fix synchronizes the in-flight permission state and stored callback so only one OS permission request can start at a time, and the callback cannot be overwritten while a request is pending.

No automated test was added because FlutterFire CI does not currently run Android plugin JVM tests, and the existing integration test setup cannot reliably drive the Android runtime permission dialog. This was verified with the Android example build plus existing Dart analysis/tests.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Copy link
Copy Markdown

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellwheatley russellwheatley merged commit 57d4c3d into main May 7, 2026
34 of 35 checks passed
@russellwheatley russellwheatley deleted the fix/18246 branch May 7, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DuplicateTaskCompletionException crash in requestPermissions() on Android due to unsynchronized requestInProgress flag

3 participants