fix(auth, iOS): add detailed error handling for Apple authorization failures#18415
fix(auth, iOS): add detailed error handling for Apple authorization failures#18415SelaseKay wants to merge 2 commits into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
Thanks for picking this up so quickly — the native side is exactly what I was hoping for. Two things I noticed when tracing what happens to the new error on the Dart side, one of which I think is worth fixing before merge: 1. The In var parsedMessage = platformException.message?.split(': ').last;The new format includes the literal Built natively: Received in Dart: — the localizedDescription and the primary Domain/Code are lost, which is the exact case (AKAuthenticationError −7026) that motivated the issue. The no-underlying case is fine, since Apple's synthesized descriptions don't contain Minimal fix: drop the colon from the label, e.g. [NSString stringWithFormat:@", Underlying Domain=%@ Code=%ld", ...]2. The structured
Happy to test the branch against the device states from the original report once it's updated. |
|
Good catch @bjrochem72. I've updated the PR. Will wait for your feedback on the test. |
|
Tested the updated branch on device (iOS 26.4 simulator, no Apple ID signed in — the — the primary Note on my harness: I couldn't pull the On "the test": I only see Unrelated: the |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Fixes #18413
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?