fix(firebase_app_check): Add play integrity check to app_check activation #9450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pcheck Added play integrity check to added safety net check for appcheck act…
…pcheck added play integrity dependency
russellwheatley
added
platform: android
nohe427
reviewed
Sep 7, 2022
| try { | ||
| FirebaseAppCheck firebaseAppCheck = getAppCheck(arguments); | ||
| firebaseAppCheck.installAppCheckProviderFactory( | ||
| SafetyNetAppCheckProviderFactory.getInstance()); |
Contributor
There was a problem hiding this comment.
I feel like SafetyNet should be behind a flag. SafetyNet is eventually being deprecated and the Play Console is warning folks about SafetyNet being present in their APKs and AABs. I think PlayIntegrityAPI should be the default choice and then optionally have a flag that can switch over to safetyNet, but not have both appcheck providers active at the same time since both provide attestation.
|
Adding my support for this issue to be resolved, I was confused today when I learned that flutterfire only supports a deprecated API for android app check. |
10 tasks
Member
|
Hey @the-recondite, thanks for the PR. Hope you don't mind, but we favored a different approach: #9646 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the play integrity check to the already present SafetyNet app check when activating firebase app_check. Previously, only the SafetyNetAppCheck was being initialized. This PR was created to fix #9178. We need the play integrity check to make sure the installation of our app is legit.
Related Issues
closes #9178
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?