fix: Exceptions inside Query.snapshots() and more now have a stack trace that correctly points to the invocation of the throwing method#9639
Merged
russellwheatley merged 2 commits intomasterfrom Oct 6, 2022
Conversation
…ace that correctly points to the invocation of the throwing method
Lyokone
approved these changes
Oct 3, 2022
Contributor
Lyokone
left a comment
There was a problem hiding this comment.
LGTM, I had no idea Stacktrace.current existed :) Thanks a lot
russellwheatley
approved these changes
Oct 6, 2022
|
Amazing, thanks @rrousselGit! |
Contributor
|
Oh, finally!! Thanks a lot!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to
StreamController.onListenshenanigans, exceptions within its callback have an incorrect stacktrace.To fix this, we can keep a reference on the caller stacktrace, and on error, report the error with that stacktrace instead.
While we're at this, this PR also changes a few
EventChanne.receiveBroadcastStreamthat did not implement a "handleError", so platform exceptions were not converted to FirebaseExceptions.Related Issues
fixes #6743
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?