Update README.md #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the link for the HTTPS trigger quickstart from /time to /time-server
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
egilmorez
approved these changes
Feb 27, 2017
puf
added a commit
that referenced
this pull request
Mar 13, 2017
1. tracks add/remove of child nodes and increments/decrements the counter 2. one function is triggered when the counter is deleted and it recounts the child nodes The delta counter in #1 is more efficient than counting all children every time, since it only needs access to the delta. The recounter function in #2 is equally inefficient as before, but is needed a lot less.
mbleigh
pushed a commit
that referenced
this pull request
May 17, 2017
* add sample for server-side rendering of a react app * update main Readme
orouz
added a commit
to orouz/functions-samples
that referenced
this pull request
Apr 23, 2018
on line 43, the assignment to `reportsId` is done using an undefined reference , and in any way the value is an object, so i believe `Object.keys` is the way to go
on line 48, i changed the naming (`currentEmployee` -> `employee`) because in `User.jsx` on line `70` there's this:
`const { employee } = this.props.currentEmployee`
so it breaks otherwise.
nicolasgarnier
added a commit
that referenced
this pull request
Apr 23, 2018
[isomorphic-react-app] fix broken user page #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the link for the HTTPS trigger quickstart from /time to /time-server