Conversation
| return | ||
|
|
||
|
|
||
| # TODO: Should really be non-blocking or client-side call. |
There was a problem hiding this comment.
I don't think we should include this example.
- There's no need for this to be blocking, AFAIK.
- The (Python) Admin SDK intentionally doesn't support sending emails from Firebase, so there's a big hand-wave.
There was a problem hiding this comment.
Do you mean, completely not cover Python support in https://firebase.google.com/docs/functions/beta/auth-blocking-events?
You're the expert on that file, so we will be directed by your opinion I think. All the Node snippets are hardcoded, fwiw.
There was a problem hiding this comment.
I think we should remove or rework this example altogether, for both Python and Node, for the reasons given above.
There was a problem hiding this comment.
Roger that! Saw your other PR (thumbs up emoji).
|
Hey @kevinthecheung, should this PR be closed in favor of #1074, or should I review this too? |
Please review. The docs use snippets from both. I just split off #1074 because it has several moving parts. |
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Lets get these merged, thanks
| firestore_client: google.cloud.firestore.Client = firestore.client() | ||
| doc = firestore_client.collection("banned").document(email).get() |
There was a problem hiding this comment.
Can we use the Firebase Admin SDK here instead?
There was a problem hiding this comment.
There was a problem hiding this comment.
We do, that's just for typing/Intellisense
3 participants
No description provided.