Skip to content

GitHub README fixes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 3 commits into from
Mar 14, 2017
Merged

GitHub README fixes #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbfa26b
Fix typo in README
jamesdaniels Mar 14, 2017
dc5e2e5
Dropped Assistant callouts
jamesdaniels Mar 14, 2017
b86dd1f
Adding npm install instructions
jamesdaniels Mar 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Uses a Firebase Storage trigger.

### [Post GitHub commits to Slack channel](/github-to-slack)

Demonstrates hows how to automatically post GitHub commits to a Slack channel using an HTTPS triggered Function.
Demonstrates how to automatically post GitHub commits to a Slack channel using an HTTPS triggered Function.

### [Automatically Moderate Images](/moderate-images)

Expand Down
8 changes: 3 additions & 5 deletions github-to-slack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,17 @@ Further reading:

See file [functions/index.js](functions/index.js) for the code.

Handling the Google Actions requests is done using the [Google Actions SDK](https://www.npmjs.com/package/actions-on-google).

The dependencies are listed in [functions/package.json](functions/package.json).


## Deploy and test

To test this sample action:
To test this integration:

- Create a Firebase Project using the [Firebase Developer Console](https://console.firebase.google.com)
- Enable billing on your project by switching to the Blaze or Flame plan. See [pricing](https://firebase.google.com/pricing/) for more details. This is required to be able to do requests to non-Google services.
- Configure this sample to use your project using `firebase --use add` and select your project.
- Install dependencies locally by running: `cd functions; npm install; cd -`
- [Add a WebHook to your GitHub repo](https://help.github.com/articles/about-webhooks/) with the following settings:
- Payload URL: `https://us-central1-<FIREBASE_PROJECT_ID>.cloudfunctions.net/githubWebhook`
- Content type: `application/json`
Expand All @@ -34,5 +33,4 @@ To test this sample action:
firebase functions:config:set slack.webhook_url="https://hooks.slack.com/services/..." github.secret="A_SECRET_YOU_DEFINED_WHEN_SETTING_UP_THE_GITHUB_WEBHOOK"
```
- Deploy your project using `firebase deploy`
- Make your action available for testing using the `gactions preview action.json`
- Test your Action on the [Google Home Web Simulator](https://g.co/actionswebsim) by saying "Talk to My Action"
- Push a commit to your GitHub repo