fix: fix ESM for ollama and google cloud plugin, added tests for ESM compatibility #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaroneee
approved these changes
Nov 22, 2024
hugoaguirre
pushed a commit
that referenced
this pull request
Nov 25, 2024
…compatibility (#1379) * fix: fix ESM for ollama and google cloud plugin, added tests for ESM compatibility * format * remove google auth from top level * skip checks * some more fixes
cabljac
pushed a commit
to invertase/genkit
that referenced
this pull request
Nov 25, 2025
…compatibility (firebase#1379) * fix: fix ESM for ollama and google cloud plugin, added tests for ESM compatibility * format * remove google auth from top level * skip checks * some more fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):