Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions genkit-tools/common/src/eval/parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ export function extractMetricsMetadata(evaluatorActions: Action[]) {
const metadata: Record<string, any> = {};
for (const action of evaluatorActions) {
metadata[action.name] = {
displayName: action.metadata![EVALUATOR_METADATA_KEY_DISPLAY_NAME],
definition: action.metadata![EVALUATOR_METADATA_KEY_DEFINITION],
displayName: (action.metadata!.evaluator as any)[
EVALUATOR_METADATA_KEY_DISPLAY_NAME
],
definition: (action.metadata!.evaluator as any)[
EVALUATOR_METADATA_KEY_DEFINITION
],
};
}
return metadata;
Expand Down
2 changes: 1 addition & 1 deletion go/ai/evaluator.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func DefineBatchEvaluator(r *registry.Registry, provider, name string, options *
metadataMap["evaluatorDisplayName"] = options.DisplayName
metadataMap["evaluatorDefinition"] = options.Definition

return (*evaluatorActionDef)(core.DefineAction(r, provider, name, atype.Evaluator, metadataMap, batchEval)), nil
return (*evaluatorActionDef)(core.DefineAction(r, provider, name, atype.Evaluator, map[string]any{"evaluator": metadataMap}, batchEval)), nil
}

// IsDefinedEvaluator reports whether an [Evaluator] is defined.
Expand Down
6 changes: 6 additions & 0 deletions js/ai/src/embedder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import { Action, defineAction, z } from '@genkit-ai/core';
import { Registry } from '@genkit-ai/core/registry';
import { toJsonSchema } from '@genkit-ai/core/schema';
import { Document, DocumentData, DocumentDataSchema } from './document.js';

/**
Expand Down Expand Up @@ -115,6 +116,11 @@ export function defineEmbedder<
metadata: {
type: 'embedder',
info: options.info,
embedder: {
customOptions: options.configSchema
? toJsonSchema({ schema: options.configSchema })
: undefined,
},
},
},
(i) =>
Expand Down
19 changes: 14 additions & 5 deletions js/ai/src/evaluator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import { Action, defineAction, z } from '@genkit-ai/core';
import { logger } from '@genkit-ai/core/logging';
import { Registry } from '@genkit-ai/core/registry';
import { toJsonSchema } from '@genkit-ai/core/schema';
import { SPAN_TYPE_ATTR, runInNewSpan } from '@genkit-ai/core/tracing';
import { randomUUID } from 'crypto';

Expand Down Expand Up @@ -146,11 +147,16 @@ export function defineEvaluator<
},
runner: EvaluatorFn<EvalDataPoint, EvaluatorOptions>
) {
const metadata = {};
metadata[EVALUATOR_METADATA_KEY_IS_BILLED] =
const evalMetadata = {};
evalMetadata[EVALUATOR_METADATA_KEY_IS_BILLED] =
options.isBilled == undefined ? true : options.isBilled;
metadata[EVALUATOR_METADATA_KEY_DISPLAY_NAME] = options.displayName;
metadata[EVALUATOR_METADATA_KEY_DEFINITION] = options.definition;
evalMetadata[EVALUATOR_METADATA_KEY_DISPLAY_NAME] = options.displayName;
evalMetadata[EVALUATOR_METADATA_KEY_DEFINITION] = options.definition;
if (options.configSchema) {
evalMetadata['customOptions'] = toJsonSchema({
schema: options.configSchema,
});
}
const evaluator = defineAction(
registry,
{
Expand All @@ -164,7 +170,10 @@ export function defineEvaluator<
evalRunId: z.string(),
}),
outputSchema: EvalResponsesSchema,
metadata: metadata,
metadata: {
type: 'evaluator',
evaluator: evalMetadata,
},
},
async (i) => {
let evalResponses: EvalResponses = [];
Expand Down
6 changes: 6 additions & 0 deletions js/ai/src/reranker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import { Action, defineAction, z } from '@genkit-ai/core';
import { Registry } from '@genkit-ai/core/registry';
import { toJsonSchema } from '@genkit-ai/core/schema';
import { Part, PartSchema } from './document.js';
import { Document, DocumentData, DocumentDataSchema } from './retriever.js';

Expand Down Expand Up @@ -124,6 +125,11 @@ export function defineReranker<OptionsType extends z.ZodTypeAny = z.ZodTypeAny>(
metadata: {
type: 'reranker',
info: options.info,
reranker: {
customOptions: options.configSchema
? toJsonSchema({ schema: options.configSchema })
: undefined,
},
},
},
(i) =>
Expand Down
11 changes: 11 additions & 0 deletions js/ai/src/retriever.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import { Action, GenkitError, defineAction, z } from '@genkit-ai/core';
import { Registry } from '@genkit-ai/core/registry';
import { toJsonSchema } from '@genkit-ai/core/schema';
import { Document, DocumentData, DocumentDataSchema } from './document.js';
import { EmbedderInfo } from './embedder.js';

Expand Down Expand Up @@ -144,6 +145,11 @@ export function defineRetriever<
metadata: {
type: 'retriever',
info: options.info,
retriever: {
customOptions: options.configSchema
? toJsonSchema({ schema: options.configSchema })
: undefined,
},
},
},
(i) => runner(new Document(i.query), i.options)
Expand Down Expand Up @@ -184,6 +190,11 @@ export function defineIndexer<IndexerOptions extends z.ZodTypeAny>(
metadata: {
type: 'indexer',
embedderInfo: options.embedderInfo,
indexer: {
customOptions: options.configSchema
? toJsonSchema({ schema: options.configSchema })
: undefined,
},
},
},
(i) =>
Expand Down
Loading