[Go] change embedder plugins to use Init and New #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will permit code to get a Retriever without looking up an action. This is how the googleai package works.
randall77
approved these changes
May 29, 2024
Contributor
|
Thanks Ian. AFAIU, we should use Is that correct? |
ssbushi
approved these changes
May 29, 2024
Contributor
Author
|
@ssbushi Yes, that's correct. We can change that if something else seems better, but let's at least be consistent for now. |
ssbushi
reviewed
May 29, 2024
| // New returns an [ai.Retriever] that uses Pinecone. | ||
| // | ||
| // apiKey is the API key to use to access Pinecone. | ||
| // If it is the empty string, it is read from the PINECONE_API_INDEX |
Contributor
There was a problem hiding this comment.
Suggested change
| // If it is the empty string, it is read from the PINECONE_API_INDEX | |
| // If it is the empty string, it is read from the PINECONE_API_KEY |
* Clean up doc strings, make them more clickable. * fix EmbedOptions type
* [Go] Simple RAG sample, using localvec --------- Co-authored-by: Ian Lance Taylor <iant@golang.org>
…tput conformance. (#251)
Contributor
Author
|
I've somehow broken this pull request by trying to merge other changes. Will start again. |
Contributor
Author
|
Replaced by #276. Sorry for the hassle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the pinecone and localvec plugins to use a
Newfunction thatreturns an
ai.Retriever, and anInitfunction that registers one with genkit.This makes the pinecone and localvec plugins consistent with each other,
and with other plugins such as googleai.