[Go] change embedder plugins to use Init and New #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the pinecone and localvec plugins to use a New function that returns an ai.Retriever, and an Init function that registers one with genkit. This makes the pinecone and localvec plugins consistent with each other, and with other plugins such as googleai.
randall77
approved these changes
May 29, 2024
Contributor
Author
|
Argh, I did not mean to include the menu samples. |
ianlancetaylor
added a commit
that referenced
this pull request
May 29, 2024
Accidentally committed in #276.
ianlancetaylor
added a commit
that referenced
this pull request
May 29, 2024
Accidentally committed in #276.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the pinecone and localvec plugins to use a New function that returns an ai.Retriever, and an Init function that registers one with genkit.
This makes the pinecone and localvec plugins consistent with each other, and with other plugins such as googleai.