Skip to content

fix(go): Debug logs change from fmt.Sprintf("%#v",d) to serialized JSON in []byte #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix(go): Debug logs change from fmt.Sprintf("%#v",d) to serialized JSON in []byte #3717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652e808
Log json []byte instead fmt.Sprintf("%#v")
peterkarabinovic Oct 10, 2025
3729e2f
Merge branch 'firebase:main' into main
peterkarabinovic Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions go/ai/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,13 @@ type ModelOptions struct {
func DefineGenerateAction(ctx context.Context, r api.Registry) *generateAction {
return (*generateAction)(core.DefineStreamingAction(r, "generate", api.ActionTypeUtil, nil, nil,
func(ctx context.Context, actionOpts *GenerateActionOptions, cb ModelStreamCallback) (resp *ModelResponse, err error) {
actionOptsBytes, _ := json.Marshal(actionOpts)
logger.FromContext(ctx).Debug("GenerateAction",
"input", fmt.Sprintf("%#v", actionOpts))
"input", actionOptsBytes)
defer func() {
respBytes, _ := json.Marshal(resp)
logger.FromContext(ctx).Debug("GenerateAction",
"output", fmt.Sprintf("%#v", resp),
"output", respBytes,
"err", err)
}()

Expand Down
6 changes: 4 additions & 2 deletions go/core/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,15 @@ func (a *ActionDef[In, Out, Stream]) Run(ctx context.Context, input In, cb Strea

// Run executes the Action's function in a new trace span.
func (a *ActionDef[In, Out, Stream]) runWithTelemetry(ctx context.Context, input In, cb StreamCallback[Stream]) (output api.ActionRunResult[Out], err error) {
inputBytes, _ := json.Marshal(input)
logger.FromContext(ctx).Debug("Action.Run",
"name", a.Name(),
"input", fmt.Sprintf("%#v", input))
"input", inputBytes)
defer func() {
outputBytes, _ := json.Marshal(output)
logger.FromContext(ctx).Debug("Action.Run",
"name", a.Name(),
"output", fmt.Sprintf("%#v", output),
"output", outputBytes,
"err", err)
}()

Expand Down
Loading