fix(js/core): Dap Action updates

[ifielker]

New requirements that the DAP action takes no input and returns an ActionMetadata array are now satisfied.

Checklist (if applicable):

• PR title is following https://www.conventionalcommits.org/en/v1.0.0/
• Tested (manually, unit tested, etc.)
• Docs updated (updated docs or a docs bug required)

[gemini-code-assist]

Summary of Changes

Hello @ifielker, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Dynamic Action Provider (DAP) to align with new architectural requirements, specifically that DAP actions must accept no input and return an array of 'ActionMetadata'. This change impacts how action data is fetched, cached, and traced, leading to a necessary double invocation of the action provider in some cases. The modifications ensure compliance with the updated API contract while acknowledging a minor risk of data inconsistency between tracing and actual usage.

Highlights

• DAP Action Signature Update: The Dynamic Action Provider (DAP) action now explicitly takes no input and is required to return an 'ActionMetadata' array, aligning with new requirements.
• Double Invocation: Due to the updated requirements, the action provider is now called twice in certain scenarios (once to fetch data, once to trace), which is reflected in updated test counts.
• Metadata Transformation: The 'transformDapValue' utility function has been refactored to flatten action metadata into a single 'ActionMetadata[]' array, matching the new output type.
• Potential Trace Mismatch: The author notes a slight possibility that the data recorded in the trace might differ from the data actually used, as the action is invoked twice.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Dynamic Action Provider (DAP) action to align with new requirements, specifically to take no input and return an array of ActionMetadata. This change correctly necessitates calling the action provider twice, which is a noted trade-off for satisfying the new contract. The changes are well-reflected in the updated tests. My review includes a suggestion to improve the robustness and conciseness of the transformDapValue function.