Skip to content

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jan 19, 2026

Fixes: #3846

Also consolidates how we treat *Ref helpers (if the helper name specifies a provider, then it needn't be specified in the name field)

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and consistency of model name handling within the js/compat-oai plugin. By introducing a dedicated utility function for parsing model names and streamlining the *Ref helper functions, it resolves an issue where slashes in model names were not correctly processed. This change simplifies model registration and ensures that model identifiers are consistently interpreted, making the plugin more reliable and easier to extend.

Highlights

  • Introduced toModelName Utility: A new utility function toModelName was added to js/plugins/compat-oai/src/utils.ts to standardize the extraction of model names, correctly handling various prefixes (e.g., '/model/', '/embedder/') and custom plugin prefixes.
  • Consolidated Model Naming Logic: The way model names are processed and registered has been unified across audio, embedder, image, and model definitions within the compat-oai plugin, ensuring consistent handling of slashes and prefixes.
  • Refactored *Ref Helpers: Helper functions like openAIImageModelRef and xaiImageModelRef were refactored to automatically inject the provider namespace (e.g., 'openai', 'xai') when defining model references, removing the need for explicit prefixes in model names (e.g., 'openai/gpt-4' becomes 'gpt-4').
  • Updated Model Definitions: Numerous model definitions across deepseek, openai, and xai sub-plugins were updated to reflect the new model naming convention, removing redundant provider prefixes from their name fields.
  • Enhanced Test Coverage: New unit tests were added for the toModelName utility in js/plugins/compat-oai/tests/utils_test.ts to validate its behavior with different prefix scenarios and model names containing slashes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a toModelName utility function to correctly handle slashes in model names and consolidates the logic for *Ref helpers to manage provider namespaces automatically. These changes significantly improve code clarity and maintainability by centralizing model name parsing and reducing redundancy. The overall approach is solid, but I've identified a potential issue in the new utility function that could lead to incorrect behavior in some edge cases. My feedback includes a suggestion to make the implementation more robust.

ssbushi and others added 2 commits January 19, 2026 18:35
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ssbushi ssbushi requested a review from pavelgj January 19, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[JS] Model name parsing fails with multiple slashes in OpenAI-compatible plugin

1 participant