feat(cli): add streaming and reasoning to dev:test-model cmd#4235
feat(cli): add streaming and reasoning to dev:test-model cmd#4235hugoaguirre merged 10 commits intomainfrom
Conversation
Summary of ChangesHello @hugoaguirre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a --stream option to the dev:test-model command, enabling tests to be run against a model's streaming API. The implementation correctly adds the necessary CLI option, passes the flag through to the test execution logic, and handles the aggregation of streamed text chunks. My review focuses on ensuring the aggregated text is correctly applied to the response object for validation. I've identified a high-severity issue where the code makes an unsafe assumption about the structure of the model's response, which could lead to data corruption. A code suggestion is provided to fix this.
Added stream test cases:
Added
reasoningvalidator:cd js/testapps/basic-gemini genkit dev:test-model --from-file=../../plugins/google-genai/tests/model-tests-tts.yaml -- tsx src/index.tsIn
model-tests-tts.yamlyou can specify how to enablereasoningfor your model.For Gemini models: