Skip to content

fix(py): fix living log and test flows in sample-flow-test tool#4545

Merged
MengqinShen merged 3 commits intomainfrom
elisa/fix/flow-test-tool
Feb 11, 2026
Merged

fix(py): fix living log and test flows in sample-flow-test tool#4545
MengqinShen merged 3 commits intomainfrom
elisa/fix/flow-test-tool

Conversation

@MengqinShen
Copy link
Contributor

@MengqinShen MengqinShen commented Feb 10, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the testing infrastructure for Python samples by improving the visibility of test execution and making the logging process more robust. The changes enable real-time feedback during flow runs and provide better debugging information in case of failures, while also preventing potential issues with external service rate limits during sequential testing.

Highlights

  • Live Logging: Implemented live logging for flow testing progress and results, providing immediate feedback during execution.
  • Subprocess Output Streaming: Refactored subprocess execution from subprocess.run to subprocess.Popen to stream output, improving visibility during long-running tests.
  • Enhanced Error Handling: Improved error handling for parsing subprocess JSON output, now including raw output for better debugging in case of failures.
  • Visible Flow Logs: Removed stdout redirection in run_single_flow.py to ensure internal flow logs are visible during execution.
  • Rate Limit Mitigation: Added a 10-second delay between sample flow executions to mitigate potential rate limiting issues with external services.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • py/samples/sample-test/review_sample_flows.py
    • Added print statements for live logging during flow testing.
    • Changed subprocess execution from run to Popen to enable output streaming.
    • Improved error handling for JSON parsing, including printing raw output on failure.
    • Introduced a 10-second delay between flow tests.
  • py/samples/sample-test/run_single_flow.py
    • Removed stdout redirection to allow flow logs to be visible.
    • Added a try-except block for asyncio.run to catch exceptions.
    • Ensured the final JSON result is printed with explicit start and end markers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces significant improvements to the flow testing and logging mechanisms. By switching to subprocess.Popen and streaming output, the review process now provides live feedback during flow execution, which is a great enhancement for user experience and debugging. The run_single_flow.py script has been updated to support this streaming and robustly handle errors during asynchronous flow execution. There are a couple of minor issues related to exception handling and import placement that could be improved for better code quality.

@MengqinShen MengqinShen changed the title fix(py): fix living log and test flows fix(py): fix living log and test flows in sample-flow-test tool Feb 11, 2026
@MengqinShen MengqinShen marked this pull request as ready for review February 11, 2026 07:56
@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@MengqinShen MengqinShen enabled auto-merge (squash) February 11, 2026 07:57
@MengqinShen MengqinShen merged commit a9b9132 into main Feb 11, 2026
19 checks passed
@MengqinShen MengqinShen deleted the elisa/fix/flow-test-tool branch February 11, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants