fix(go/plugins/anthropic): resolve models using aliases#4703
fix(go/plugins/anthropic): resolve models using aliases#4703hugoaguirre merged 4 commits intomainfrom
Conversation
Summary of ChangesHello @hugoaguirre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Anthropic plugin by introducing support for model aliases. Previously, users had to specify the exact, date-suffixed model ID (e.g., "claude-3-5-sonnet-20240620"). With this change, users can now use simpler aliases like "claude-3-5-sonnet", and the system will automatically resolve it to the latest available full model ID. This significantly improves the developer experience by making model selection more intuitive and less prone to errors when new model versions are released. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful feature to resolve Anthropic model aliases to their full, versioned names. The implementation is clean, and the new logic is well-tested with the addition of TestResolveModelID. I have one suggestion to improve performance by caching the list of models to avoid repeated API calls. Overall, this is a great enhancement.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to resolve Anthropic model aliases to their full, versioned names, which is a great enhancement for user experience. The implementation includes a caching mechanism for the list of available models to improve performance, which is well-thought-out. The logic for resolving aliases by finding the lexicographically latest model version is sound, and the addition of unit tests for this logic is appreciated. I have one suggestion to further improve the concurrency handling of the model cache to prevent potential performance bottlenecks.
Providing a claude model using an alias without the
@YYYYMMDDformat will resolve into a valid model nameChecklist (if applicable):