Skip to content

Conversation

@jwngr
Copy link

@jwngr jwngr commented Feb 22, 2017

Description

Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the 0.0.0 version placeholder in the bower.json and package.json files. So, we can finally add the actual version numbers back into these files.

Code sample

N/A

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.977% when pulling f013496 on jw-add-version-numbers-to-json-files into da8e4ea on master.

Copy link

@cbraynor cbraynor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbraynor cbraynor assigned jwngr and unassigned cbraynor Feb 22, 2017
@jwngr jwngr merged commit 823664f into master Feb 22, 2017
@jwngr jwngr deleted the jw-add-version-numbers-to-json-files branch February 22, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants