Skip to content

Allowing Firebase 4.x.x as a peer dependency #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allowing Firebase 4.x.x as a peer dependency #172

wants to merge 1 commit into from

Conversation

@asciimike
Copy link
Contributor

@asciimike asciimike commented Mar 29, 2018

Should solve #156

@asciimike asciimike requested a review from abeisgoat March 29, 2018 18:26
@sebastianovide sebastianovide mentioned this pull request Apr 18, 2018
Closed
@doovers
Copy link

doovers commented Jun 13, 2018

@mcdonamp Can you add 5.x.x to this too?

@asciimike
Copy link
Contributor Author

asciimike commented Jun 13, 2018

@doovers I was planning on relying on #169 to solve this (as it changes around more than a few things, but should also solve this problem). I'll close this PR because of that.

@asciimike asciimike closed this Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abeisgoat abeisgoat Awaiting requested review from abeisgoat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asciimike @doovers