docs: Update first 2 examples to work as written#625
Open
bpedroza wants to merge 1 commit intofirebase:mainfrom
Open
docs: Update first 2 examples to work as written#625bpedroza wants to merge 1 commit intofirebase:mainfrom
bpedroza wants to merge 1 commit intofirebase:mainfrom
Conversation
…ainException: Provided key is too short
bshaffer
reviewed
Mar 23, 2026
| use Firebase\JWT\Key; | ||
|
|
||
| $key = 'example_key'; | ||
| $key = 'example_key_of_sufficient_length'; |
Collaborator
There was a problem hiding this comment.
Hmm, I believe this is not long enough (it needs to be 256 characters).
I have a PR coming which will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the examples in the readme throw a
DomainExceptionbecause the key 'example_key' is too short. This is just an update to the readme to provide an example that will work out of the box.