Skip to content

Auto-update dependencies.#2782

Merged
thatfiredev merged 6 commits intomasterfrom
dpebot-repositorygardener
May 5, 2026
Merged

Auto-update dependencies.#2782
thatfiredev merged 6 commits intomasterfrom
dpebot-repositorygardener

Conversation

@dpebot
Copy link
Copy Markdown
Collaborator

@dpebot dpebot commented Apr 30, 2026

Brought to you by your friendly Repository Gardener.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions across several modules, including Firebase BoM, AndroidX components, and Kotlin. The review feedback suggests utilizing the Version Catalog for hardcoded dependencies to improve maintainability and identifies a version mismatch for the Firebase BoM between the module files and the central catalog.


// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
implementation(platform("com.google.firebase:firebase-bom:34.7.0"))
implementation(platform("com.google.firebase:firebase-bom:34.12.0"))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Firebase BoM version 34.12.0 used here is inconsistent with the version 34.11.0 defined in gradle/libs.versions.toml. Please update the Version Catalog and use the libs.firebase.bom reference to maintain consistency across the project.

    implementation(platform(libs.firebase.bom))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, looks like it didn't work...

Comment thread admob/app/build.gradle.kts
Comment thread firestore/app/build.gradle.kts
Comment thread messaging/app/build.gradle.kts
Comment thread messaging/app/build.gradle.kts
Comment thread internal/lint/build.gradle.kts
@dpebot dpebot force-pushed the dpebot-repositorygardener branch 3 times, most recently from 6d200f2 to 379ad6f Compare May 3, 2026 22:14
@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 379ad6f to 18c1367 Compare May 4, 2026 22:14
Comment thread gradle/libs.versions.toml Outdated
@thatfiredev thatfiredev added the automerge Summon MOG for automerging label May 5, 2026
@thatfiredev thatfiredev merged commit f92868f into master May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Summon MOG for automerging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants