Skip to content

Auto-update dependencies.#2783

Merged
thatfiredev merged 1 commit intomasterfrom
dpebot-repositorygardener
May 5, 2026
Merged

Auto-update dependencies.#2783
thatfiredev merged 1 commit intomasterfrom
dpebot-repositorygardener

Conversation

@dpebot
Copy link
Copy Markdown
Collaborator

@dpebot dpebot commented May 5, 2026

Brought to you by your friendly Repository Gardener.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin (AGP) to version 9.2.1 and increments the Android Lint dependencies to version 32.2.1. The reviewer suggested moving these hardcoded Lint versions into the project's Version Catalog to maintain a single source of truth and ensure consistency with the AGP version, or at least using a local variable to reduce repetition.

Comment on lines +12 to +14
compileOnly("com.android.tools.lint:lint-api:32.2.1")
testImplementation("com.android.tools.lint:lint:32.2.1")
testImplementation("com.android.tools.lint:lint-tests:32.2.1")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Android Lint version is hardcoded and repeated across multiple dependencies. Since the project uses a Version Catalog (libs.versions.toml), it is recommended to define the Lint version there to maintain a single source of truth and ensure it stays in sync with the Android Gradle Plugin (AGP) version (the Lint version 32.2.1 correctly corresponds to AGP 9.2.1). At a minimum, using a local variable within this block reduces repetition and simplifies future updates.

    val lintVersion = "32.2.1"
    compileOnly("com.android.tools.lint:lint-api:$lintVersion")
    testImplementation("com.android.tools.lint:lint:$lintVersion")
    testImplementation("com.android.tools.lint:lint-tests:$lintVersion")

@thatfiredev thatfiredev merged commit 3c2eda8 into master May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants