Skip to content

Conversation

@jpoag
Copy link

@jpoag jpoag commented Aug 3, 2018

Demo project for using Cloud Functions from App. Includes an echo server.

This pull request is primarily to reproduce an issue with Cloud Functions. However, with a little cleanup, this would be very useful in it's own right.

@bklimt
Copy link

bklimt commented Sep 11, 2018

Hi @jpoag, thanks for taking the time to make this. I see it has some conflicts with the existing sample app that would need to be resolved. I'm guessing when you started creating this sample app, the other one didn't exist yet? Then is this pull request obsolete?

@jpoag
Copy link
Author

jpoag commented Sep 11, 2018

The other example did not exist or wasn't in the master branch when I wrote this. This currently serves as the reproduction example for #32 , so as soon as that is closed (which should be soon-ish) we can reject the pull request and I'll close out my fork.

@jpoag
Copy link
Author

jpoag commented Sep 21, 2018

No longer needed. Issue #32 has been fixed in C++ SDK release 5.3.0 https://firebase.google.com/support/release-notes/cpp-relnotes

@jpoag jpoag closed this Sep 21, 2018
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants