Merged
Conversation
Function to InitializeAuthenticaionLayer. Function to InitializeLoginLayer. Function to InitializeSignUpLayer.
…into redesign-auth-screen
Separating update functions. Cleaning up TicTacToeLayer constructor. Cleaning up MainMenuScene init. Renaming uuid to uid.
…into modularize-main-features
DellaBitta
requested changes
Jul 22, 2020
Nit: new line. removing obvious comment. Making repeated comments more unique.
DellaBitta
approved these changes
Jul 23, 2020
Contributor
DellaBitta
left a comment
DellaBitta
left a comment
There was a problem hiding this comment.
Approved, but please ping Alex about the use of futures.
alexames
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a developer, I would like to have it so repeatable chunks of code are made into modules, so that the code is much more readable to new developers. As of the midpoint refocus, the code is currently not very well structured and resides mainly in the init() class function for both scenes, chopping this large contiguous portion of code will allow for a code base that is better organized and easier to build on while also removing duplicates setup calls for creating sprites, text fields, labels and touch listeners.
examples:
making a add border feature for text fields (Previous PR)
creating the auth screen is separate from main menu