UI/UX redesign && Pressed Button State.#75
Merged
alexames merged 9 commits intofirebase:demo-devfrom Aug 4, 2020
Merged
Conversation
Function to InitializeAuthenticaionLayer. Function to InitializeLoginLayer. Function to InitializeSignUpLayer.
…into redesign-auth-screen
…into upstream/demo-dev
…into upstream/demo-dev
…into upstream/demo-dev
…into ui/ux-redesign
DellaBitta
requested changes
Aug 4, 2020
Contributor
DellaBitta
left a comment
DellaBitta
left a comment
There was a problem hiding this comment.
Check the commnet about adding a method to a method or a function to a function. Then when it's fixed up properly ping me again and I'll redo the review.
Right now there are more lines being reported as having changes due to a large block of code being freshly indented.
DellaBitta
approved these changes
Aug 4, 2020
Contributor
DellaBitta
left a comment
DellaBitta
left a comment
There was a problem hiding this comment.
LGTM. Alex should review it, too. There are some good changes here.
alexames
reviewed
Aug 4, 2020
alexames
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to the setup script to move the google-services.json in both the executable and debug directory.
Small change to the readme.md to specify enabling email auth and anonymous auth.
Adding
Layout shifting and overall design change.
Updating leave button to consolidate functionality and clean up code to follow the other buttons.
Updated logic to clear labels and text fields from login and sign_up layer accordingly, including releasing user_result future.
Added a handful of assets including user_record panel, login panel, sign_up panel, game_menu panel, auth panel, game icon, return button, back button.
Adding pressed state for each button.