Added missing await to beforeEach #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideast
approved these changes
Jul 6, 2023
Member
davideast
left a comment
davideast
left a comment
There was a problem hiding this comment.
@JorisPhilipsen Thank you! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
unit-test-security-rules-v9part of the project in thebeforeEachmethod there is an await missing, causing the npm command:test-databaseto fail.I also have an issue with it timing out to early when running:
This can be fixed by replacing the npm command:
test-databasewith:(Simply adding a longer timeout).
I've decided to only add the await in this PR, because the timeout issue doesn't happen on every machine.