add RC snippets #104
Merged
add RC snippets #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
May 7, 2020
| function addNewCondition(template) { | ||
| template.conditions.push({ | ||
| name: 'android_en', | ||
| expression: 'device.os == \'android\' && device.country in [\'us\', \'uk\']', |
Contributor
There was a problem hiding this comment.
If you use " for the string you won't have to escape the ':
"device.os == 'android' && device.country in ['us', 'uk']"
Contributor
Author
There was a problem hiding this comment.
ESLint is yelling at me, should I ignore it?
Contributor
There was a problem hiding this comment.
Maybe using ` instead of " will make it stop yelling?
Contributor
Author
There was a problem hiding this comment.
It is still angry 22:17 error Strings must use singlequote quotes
Contributor
There was a problem hiding this comment.
Eh ok not worth fighting more, but thats strange
samtstern
reviewed
May 7, 2020
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { |
Contributor
There was a problem hiding this comment.
Check out the package.json for some of the other modules. You should:
- Make sure this is included in
lerna.json - Get rid of the
testscript that failes - Add a
compilescript like the others
Contributor
Author
There was a problem hiding this comment.
Hmmm, this should have been in there. Thanks for pointing it out. I'll add it.
samtstern
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snippets for Firebase Remote Config.